Support pull_request_target event type #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcaversaccio
added a commit
to pcaversaccio/createx
that referenced
this pull request
Dec 18, 2024
### 🕓 Changelog This PR updates the [`LCOV`](https://github.com/linux-test-project/lcov) version to the latest release, [`2.2`](https://github.com/linux-test-project/lcov/releases/tag/v2.2), in the `coverage` CI pipeline. It also introduces a temporary workaround for the `Verify minimum coverage` step, as `LCOV` `2.2` is not yet supported in [`zgosalvez/github-actions-report-lcov@v4`](https://github.com/zgosalvez/github-actions-report-lcov/tree/v4), as outlined in issue [#168](zgosalvez/github-actions-report-lcov#168). Additionally, the [`romeovs/[email protected]`](https://github.com/romeovs/lcov-reporter-action) has been updated and is now triggered for `pull_request_target` events as well (see PR [#63](romeovs/lcov-reporter-action#63)). --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pull_request_targetevent is an alternative to thepull_requestevent but with some different security considerations. Docs.We use it on private repositories to allow dependabot access to our secrets, safe in the knowledge that a private repo can't expose our secrets to drive-by malicious PRs.
This is a simple change that extends the logic for "pull_request" to "pull_request_target" for comparisons of changes, etc.